Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mid-threat antag: Pirates #8340

Merged
merged 24 commits into from
Oct 20, 2023
Merged

Conversation

hyperioo
Copy link
Contributor

@hyperioo hyperioo commented Oct 12, 2023

About The Pull Request

This PR implements a new antag faction whose goal is to plunder the ship for valuable loot before getting back to their base (and not being killed by the crew). The raiding shuttle has several loot crates that must be filled with loot (no need to close the crates) and be inside the shuttle to count toward the objective.

Comes with:

  • New pirate base to get geared
  • New pirate shuttle to raid CEV Eris
  • A few predefined raiding locations around the ship
  • Their own pirate channel for in-raid communication
  • A timed objective - you have 45 minutes to steal stuff.
  • A plunder objective - you must steal 15000 credits of loot per pirate.
  • Mid-thread gear (mostly AKs and bulletproof vests)
  • A hailer to check the current looted value (one minute cooldown)
  • A new rum keg (like the beer keg)

Raid shuttle cannot go back to Eris once it has gone back to pirate base. Automatic mechanisms prevent the pirate shuttle from going back to pirate base if there is an alive outsider inside the shuttle so that its location remains undiscovered.

Numerical values might be adjusted depending on player feedback. The timed objective will be improved later to make it more interesting (like if you reach the loot threshold, the mission duration is extended and you have to steal more loot to extend more and more).

The faction has a temporary cartoonish pirate theme (the already-existing pirate costume) but custom stuff might come later to make them more stylish with their own sprites.

Pirate base:
image

Pirate shuttle with loot crates and hailer:
image

Ready to breach the ship:
image

Why It's Good For The Game

Provide more diversity for out-of-ship antags alongside blitz and serbs. Not as "sneaky lone wolf" as blitz, but not as "end of round" threatening as serbs.

Testing

  • Spawned as pirate by forcing pirate in storyteller panel
  • Checked objectives were properly displayed
  • Entered the shuttle, flew to the ship
  • Stole some stuff, checked that hailer is working well
  • Checked that shuttle cannot launch with alive non-pirate on board
  • Flew back to base, enjoy greentext
  • Checked shuttle could not go back to Eris

Changelog

🆑 Hyperio
add: Add new Pirates antags : pirate base, pirate shuttle, landmark locations, pirate channel, pirate objectives, pirate hailer
/:cl:

@SirRichardFrancis
Copy link
Member

No screenshots?
image

So basically it's a meme version of Serbs, just less powerful?

Can't spawn without at least two ghosts too. If game needed "Serbs, but not as threatening", then solo Serb could be allowed to spawn. Would do the thing and give lone observer something to do (since blitzshell is a sad joke and incredibly unfun to play as).

@thevandie
Copy link
Contributor

If game needed "Serbs, but not as threatening", then solo Serb could be allowed to spawn.

Nah nah nah, this has merit
More flavor is nice, and I personally wanna build off of this with pirate variations
Hell, we already have some of the sprites for that, Jimmy's IH deserters
More variations of serbs is a cool concept and adds some flavor the game is kinda missing

@thevandie
Copy link
Contributor

But yes, also add solo serb please
They'd both be good for the game

@hyperioo hyperioo marked this pull request as ready for review October 13, 2023 20:36
@thevandie
Copy link
Contributor

Use. Real. Walls.

@Mycah142
Copy link
Contributor

Use. Real. Walls.

Why? It's a shuttle. You want people to be able to dismantle it or something?

@thevandie
Copy link
Contributor

thevandie commented Oct 14, 2023

no no, I mean make proper walls that actually look good and not like it's from 20 years ago
even if it's just a normal wall sprite, it should be a normal wall
mostly with the base

(I have a vendetta against the old bay serb base and shuttle sprites)

@hyperioo
Copy link
Contributor Author

In another PR we would have to add to unsimulated walls the logic that changes the wall sprites depending on other nearby walls so that we have an unsimulated version of the classic Eris walls. It's not much to do.

@hyperioo hyperioo merged commit 4b7e693 into discordia-space:master Oct 20, 2023
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants