Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lapsv2 support #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add lapsv2 support #159

wants to merge 1 commit into from

Conversation

dadevel
Copy link

@dadevel dadevel commented Jan 9, 2024

The name of the LDAP attributes changed from LAPS Legacy to LAPSv2.
This PR adds checks for the new msLAPS-PasswordExpirationTime attribute.

References:

@dirkjanm
Copy link
Owner

hey, thanks for the PR, great idea to add this. A few issues come to mind looking at the code:

  • it should be a separate variable for laps v1 and laps v2 since if one is present in the schema it doesn't mean that the other is also present
  • I don't see any code added that actually queries this attribute when gathering computer objects (this is also the part that would include the correct attribute(s) based on which version of LAPS is there)

Am I missing something here or is this not yet present in the PR?

@dadevel
Copy link
Author

dadevel commented Jan 10, 2024

Hey you're totally right, I added the missing part. But I'm not sure if something else is still missing, because I couldn't test it yet. Probably should've marked the PR as draft.

@dadevel dadevel force-pushed the patch-1 branch 2 times, most recently from f300515 to 4a2b6eb Compare June 22, 2024 16:43
@dadevel
Copy link
Author

dadevel commented Jun 22, 2024

Hi @dirkjanm I finally got around to testing this properly. I think the PR is ready now.

image

image

@mpgn
Copy link

mpgn commented Sep 17, 2024

Hello @dirkjanm , any news to have this feature ? lapsv2 is now very very common :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants