Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch survey name to rubin_sim #896

Merged
merged 3 commits into from
Apr 11, 2024
Merged

switch survey name to rubin_sim #896

merged 3 commits into from
Apr 11, 2024

Conversation

mschwamb
Copy link
Collaborator

@mschwamb mschwamb commented Apr 9, 2024

switch survey name to rubin_sim so that it's clear this is running on rubin_sim simulated pointing databases. This way we can start to develop the version that will use the real rubin pointing data as "lsst"

Fixes #886 .

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

switch survey name to rubin_sim so that it's clear this is running on rubin_sim simulated pointing databases. This way we can start to develop the version that will use the real rubin pointing data as "lsst"
@mschwamb mschwamb requested a review from astronomerritt April 9, 2024 22:11
Copy link
Contributor

@astronomerritt astronomerritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making the change - looks like it was another one of those fiddly ones.

@mschwamb mschwamb merged commit 65e7845 into main Apr 11, 2024
6 checks passed
@mschwamb mschwamb deleted the rename_survey branch April 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the name of survey used in running simulation
2 participants