Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing name of results SQL database table. #895

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

astronomerritt
Copy link
Contributor

Fixes #891.

  • Changed the table name in the SQL output option from "pp_results" to "sorcha_results".
  • Added a message to the log which supplies the table name.
  • Changed the utility createResultsSQLDatabase.py to look for "sorcha_results".
  • Changed the unit tests to reflect this change.
  • Changed one of the test files to reflect this change.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt astronomerritt requested a review from mschwamb April 9, 2024 15:44
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (6de92fd) to head (c9a38e3).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   79.83%   79.70%   -0.13%     
==========================================
  Files          68       68              
  Lines        3020     3050      +30     
==========================================
+ Hits         2411     2431      +20     
- Misses        609      619      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschwamb mschwamb merged commit f630f09 into dirac-institute:main Apr 9, 2024
7 of 8 checks passed
@astronomerritt astronomerritt deleted the database_rename branch April 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants