New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming state vectors. #893

Merged

mschwamb merged 1 commit into dirac-institute:main from astronomerritt:state_vector_rename

Apr 9, 2024

Contributor

astronomerritt commented Apr 9, 2024

Fixes #874.

Renamed all state vector columns throughout code.
Updated unit tests.
Updated notebooks.
Renamed columns in test files.
Renamed columns in goldens.
Renamed columns in files used for golden generation and benchmarking.

I think I caught everything.

Review Checklist for Source Code Changes

Does pip install still work?
Have you written a unit test for any new functions?
Do all the units tests run successfully?
Does Sorcha run successfully on a test set of input files/databases?
Have you used black on the files you have updated to confirm python programming style guide enforcement?


          Renaming state vectors.

6cfe048

astronomerritt requested a review from mschwamb

April 9, 2024 13:28

mschwamb approved these changes

View reviewed changes

mschwamb merged commit dd43d86 into dirac-institute:main

6 checks passed

astronomerritt deleted the state_vector_rename branch

April 15, 2024 15:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet