Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix H columns for single-filter runs #768

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

astronomerritt
Copy link
Contributor

Fixes #760.

This makes sure columns are consistent across single and multi-filter runs by ensuring that both have the 'H_[mainfilter]' and 'H_filter' columns in output. In the case of a single filter run, these two columns will be identical.

(We assume that in the case of a single-filter run, the user will have supplied H in the relevant filter.)

The unit test for PPCalculateApparentMagnitude now also checks to make sure both columns are created when a single observing filter is provided.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3ed452) 74.82% compared to head (a27f0cf) 74.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #768   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files          66       66           
  Lines        3023     3023           
=======================================
  Hits         2262     2262           
  Misses        761      761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt astronomerritt merged commit 4e9c5b9 into dirac-institute:main Jan 10, 2024
8 of 10 checks passed
@astronomerritt astronomerritt deleted the fix_H_columns branch April 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check same columns are created/added when using 1 versus multiple filters
2 participants