Fix H columns for single-filter runs #768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760.
This makes sure columns are consistent across single and multi-filter runs by ensuring that both have the 'H_[mainfilter]' and 'H_filter' columns in output. In the case of a single filter run, these two columns will be identical.
(We assume that in the case of a single-filter run, the user will have supplied H in the relevant filter.)
The unit test for PPCalculateApparentMagnitude now also checks to make sure both columns are created when a single observing filter is provided.
Review Checklist for Source Code Changes