created a demo notebook to demonstrate how to calculate LSST bandpass colours #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwamb
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Very close to being complete. You'll need to include it in the documents readthedocs page for the notebook to be visible (editing https://github.com/dirac-institute/sorcha/blob/main/docs/notebooks.rst) and also adding in any packages you need installed to requirements.txt (https://github.com/dirac-institute/sorcha/blob/main/docs/requirements.txt)
|
updated requested files! |
mschwamb
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new demo notebook that takes (and credits!) spectrum of the TNO 2002 PN34 and walks through how a user could convert it into a colour in the LSST bandpass for their models. Requires rubin_sim installation for the user to run, but for the RTD the outputs should already have been ran and have outputs displayed.