Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040.
CombinedDataReader.check_aux_object_ids()
.Initially I implemented this in the silliest way possible, by checking each individual element in one ObjID list to make sure it exists in the other list. This is O(n^2) complexity -- runtime scales quadratically with the size of the data -- and I should have known better. I plead temporary insanity.
It's now using collections.Counter() to compare one list's count of unique elements to the other. This is O(n) so runtime scales linearly with data size.
On an input file of 250,000 rows it takes 150ms.
(Not twelve minutes.)
Review Checklist for Source Code Changes