Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default footprint_edge_threshold value #1039

Merged

Conversation

astronomerritt
Copy link
Contributor

Fixes #1038.

  • Changed the default footprint_edge_threshold value in all configuration files packaged within Sorcha to 2.0arcsec, which is equivalent to the 10px value we got from DM.
  • Minor edits to the text of the config files.
  • Adjusted unit test.
  • Regenerated goldens.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (bbece40) to head (f14c63f).
Report is 315 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   81.14%   81.11%   -0.04%     
==========================================
  Files          70       70              
  Lines        3166     3166              
==========================================
- Hits         2569     2568       -1     
- Misses        597      598       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt astronomerritt marked this pull request as ready for review October 17, 2024 14:02
Copy link
Collaborator

@mschwamb mschwamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should be changing the goldens. It doesn't matter what we pick, we just need to pick something for the goldens as we have unit tests. So I suggest leave it.

@astronomerritt
Copy link
Contributor Author

Reverted the goldens :)

@astronomerritt astronomerritt merged commit 00c84be into dirac-institute:main Oct 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added minimum pixel distance value to default LSST Config files
2 participants