Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying detection efficiency validation notebook. #1035

Merged

Conversation

astronomerritt
Copy link
Contributor

The notebook demonstrating the fading function/detection efficiency had a lot of extraneous code and while-loops instead of array operations, and was also missing an explanation of the fading function. I had to edit it anyway to make plots for the paper, so figured I may as well overhaul it while I was there.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (c2b800c) to head (59c9f77).
Report is 249 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   80.90%   81.14%   +0.23%     
==========================================
  Files          70       70              
  Lines        3148     3166      +18     
==========================================
+ Hits         2547     2569      +22     
+ Misses        601      597       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt astronomerritt merged commit 571956a into dirac-institute:main Oct 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants