Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating column name #33

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Updating column name #33

merged 3 commits into from
Nov 11, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #31.

  • Changed the column name in lsst_comet_activity.py to trailedSourceMagTrue so it actually works now.
  • Updated the unit test.
  • Tested it. It works.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha Add-ons run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@mschwamb mschwamb marked this pull request as ready for review November 11, 2024 14:50
@mschwamb mschwamb merged commit 06b23d2 into main Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwamb mschwamb mschwamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong column name in lsst_comet_activity.py
2 participants
@astronomerritt @mschwamb