Skip to content

Commit

Permalink
linter updates
Browse files Browse the repository at this point in the history
  • Loading branch information
mschwamb committed Jan 13, 2025
1 parent c8f5fa8 commit f9514a3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
11 changes: 6 additions & 5 deletions src/sorcha_addons/activity/lsst_comet/lsst_comet_activity.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def __init__(
) -> None:
super().__init__(required_column_names)

def checkPhysical(self, df : pd.DataFrame):
def checkPhysical(self, df: pd.DataFrame):
if (df.k > 0).any():
raise ValueError("Check complex parameters file. k > 0 is not a physical value")

def compute(
self,
df: pd.DataFrame,
Expand Down Expand Up @@ -101,14 +101,15 @@ def name_id() -> str:
"""
return "lsst_comet"

def maxBrightness(self,
def maxBrightness(
self,
df: pd.DataFrame,
observing_filters: List[str],
q: List[float],
delta: List[float],
alpha: List[float],
):
):

self._validate_column_names(df)
self.checkPhysical(df)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ def name_id() -> str:
"""
return "sinusoidal"

def maxBrightness(self, df : pd.DataFrame) -> float:
return -df["LCA"] #note this - because magnitudes are weird
def maxBrightness(self, df: pd.DataFrame) -> float:
return -df["LCA"] # note this - because magnitudes are weird

0 comments on commit f9514a3

Please sign in to comment.