-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a neighborhood search to the TrajectoryExplorer #745
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment
@@ -20,6 +20,54 @@ | |||
logger = kb.Logging.getLogger(__name__) | |||
|
|||
|
|||
def configure_kb_search_stack(search, config): | |||
"""Configure the kbmod SearchStack object from a search configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we're referring to the StackSearch object as a SearchStack
Presumably should also rename method to configure_kb_stack_search
Hold on with this please. I am using this branch. |
Add a search that will perform a hyper-localized search. This search effectively uses a small neighborhood around a given trajectory (both in terms of starting pixel and velocities) and returns all results from this neighborhood. This localized set can be used to:
As part of this change we remove a small optimization from the core search (which did not bother to sort trajectories with LH <= -1.0 since we knew they would be filtered eventually). This removes that optimization so we can get the full grid of nearby trajectories.