Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a neighborhood search to the TrajectoryExplorer #745

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jeremykubica
Copy link
Contributor

Add a search that will perform a hyper-localized search. This search effectively uses a small neighborhood around a given trajectory (both in terms of starting pixel and velocities) and returns all results from this neighborhood. This localized set can be used to:

  • refine trajectories by searching a finer parameter space around the best results found by the initial search, or
  • collect a distribution of trajectories and their likelihoods around a single result.

As part of this change we remove a small optimization from the core search (which did not bother to sort trajectories with LH <= -1.0 since we knew they would be filtered eventually). This removes that optimization so we can get the full grid of nearby trajectories.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment

@@ -20,6 +20,54 @@
logger = kb.Logging.getLogger(__name__)


def configure_kb_search_stack(search, config):
"""Configure the kbmod SearchStack object from a search configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we're referring to the StackSearch object as a SearchStack

Presumably should also rename method to configure_kb_stack_search

@DinoBektesevic
Copy link
Member

Hold on with this please. I am using this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants