Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fixed Image Organisation #51

Merged
merged 1 commit into from
Jul 29, 2024
Merged

DOC: Fixed Image Organisation #51

merged 1 commit into from
Jul 29, 2024

Conversation

deka27
Copy link
Member

@deka27 deka27 commented Jul 20, 2024

Blog Post Image Organization

Overview

This PR corrects the image organization in _static/images folder

Issue

This PR fixes - Issue 50

Proposal Idea

The idea is to move images from the main folder to respective contributor folder. This helps for better organization.

_static/images/gsoc/[year]/[name_of_contributor]

Key Changes

  • Images have been moved from main folder to respective contributor folder
  • Links for images have been updated for respective contributor and blogs

Testing

  • Verified all posts render correctly on the development server

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 20, 2024 •
edited
Loading

🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/51/

@deka27
Copy link
Member Author

deka27 commented Jul 20, 2024

@skoudoro , I couldn't find the implementation of the remaining 9 images. I am not even sure if they are being utilized. I tried removing these files and creating a build. I had a successful build with no issues. If they are unnecessary we can either remove them or keep them in a separate folder.

The actual logo photos are being pulled from the folder logos, not these files. Similar for banner, etc.

image

@deka27 deka27 self-assigned this Jul 20, 2024
@deka27 deka27 added the documentation Improvements or additions to documentation label Jul 20, 2024
skoudoro
skoudoro approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I am ok with that. it helps also to give credit to the author. merging

@skoudoro skoudoro merged commit 2638daa into dipy:master Jul 29, 2024
3 checks passed
@skoudoro skoudoro mentioned this pull request Jul 29, 2024
Closed
github-actions bot added a commit that referenced this pull request Jul 29, 2024
@github-actions
DOC: Fixed Image Organisation (#51) 2638daa
01b4f28
itellaetxe added a commit to itellaetxe/dipy.org that referenced this pull request Jul 29, 2024
@itellaetxe
Merge remote-tracking branch 'upstream/master' into inigo_week_6_7_bl…
5498e95 
…ogpost

* upstream/master:
  DOC: Adds Iñigo's week 6 and week 7 blogposts (dipy#47)
  DOC: Blogpost_KD_Week7 (dipy#48)
  DOC: Blog-Migration (dipy#49)
  DOC: Fixed Image Organisation (dipy#51)
  NF: Added Sidebar to blog.html (dipy#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

@itellaetxe itellaetxe Awaiting requested review from itellaetxe

Assignees

@deka27 deka27

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deka27 @skoudoro