-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Repairs broken link to Iñigo's repo in week 5 blogpost #46
FIX: Repairs broken link to Iñigo's repo in week 5 blogpost #46
Conversation
The link pointing to the Variational Autoencoder Module in the tractoencoder_gsoc repo was pointing to an old file name.
🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/46/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @itellaetxe,
see my comment below
@@ -23,7 +23,7 @@ Also, they provided their code in TensorFlow, so I started adapting it to our us | |||
What is coming up next week | |||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|||
I will continue working on the conditional AutoEncoder next week, but you can see the progress `here <https://github.com/itellaetxe/tractoencoder_gsoc/blob/main/src/tractoencoder_gsoc/models/cvae_model.py>`_. | |||
I will continue working on the conditional AutoEncoder next week, but you can see the progress `here <https://github.com/itellaetxe/tractoencoder_gsoc/blob/main/src/tractoencoder_gsoc/models/vae_model.py>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not look like a permalink. any change will break again this link.
Please, can you replace with this:
https://github.com/itellaetxe/tractoencoder_gsoc/blob/56ddacd8f9a2c6ac30a38c1c141bf60cc1b2d862/src/tractoencoder_gsoc/models/vae_model.py
As you can see, the permalink contains the commit number which is important in this case. thanks for the future update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, I see now. Makes sense. Thank you. Updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, merging
* FIX: Repairs broken link to Iñigo's repo The link pointing to the Variational Autoencoder Module in the tractoencoder_gsoc repo was pointing to an old file name. * FIX: Repairs broken link to Iñigo's repo with the actual permalink to the file d8d1a28
The link pointing to the Variational Autoencoder Module in the tractoencoder_gsoc repo was pointing to an old file name in Iñigo's week 5 blogpost.
Updates the link to a file that won't be renamed.