Add Probabilistic to GPUStreamlines #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36000
changed the title
…random BF, UI changes, cleanups
… in ptt; refactor some code to be more readable
arokem
changed the title
|
We're thinking of merging this branch in to the main branch, in preparation for a potential ISMRM abstract about all the work that @36000 did over the summer on this. Does this cause an issue for others using this code? @FelixLiu-SF in particular: are you and your team relying on the code currently on master for your pipelines? If so, please let us know as soon as possible, so that we can find a solution. One option would be to create a separate fork (or repo) for the new work, so that you can continue to rely on the API and functionality that are currently here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
-> Adds model agnostic probabilistic option
-> Adds first draft of a model agnostic PTT option
-> Handle c vs fortran order for all inputs, not just dataf
-> Moves all the run*.py files into one so I only had to make changes in one place (If there is a reason this was in four files, I can put it back)