Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troubleshooting fixes #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeroenterheerdt
Copy link
Contributor

@jeroenterheerdt jeroenterheerdt commented Jan 23, 2025

As I was working on making sensors and groups work for the intent view, I needed the troubleshooting view to work...
As I was fixing troubleshooting view I discovered it has a lot of repetitive code and needs maintenance for new attributes added.

So I am also offering troubleshooting-v2 that requires no maintenance as attributes are automatically updated and added. This version is maintenance free and much more elegant.

Note that both these troubleshooting view still rely on the assist group that is going away once the integration is updated, but either should be easily updated to just inspect that domain instead of the group.

Hope you find this helpful!

@dinki
Copy link
Owner

dinki commented Jan 23, 2025

image

Thanks for working on this. Something I've wanted to do as it is handy to have for new users. I tried the modifications to the original and when I browse to it it is obscured by the the popup. These lines should be removed:

template:
  - variable_template
  - body_template

To explain a bit, I originally wrote this for folks who had issues getting things set up and were having trouble figuring out what was wrong. This view is standalone as the template would not display properly due to misconfiguration by the user. Having this view as a standalone helped figure out what was wrong.

Fast forward a bit and I've done some improvements to the dashboard that handle things better and errors are a bit easier to spot. This view is still of value though.

I haven't looked at v2 yet.

@jeroenterheerdt
Copy link
Contributor Author

jeroenterheerdt commented Jan 23, 2025

Interesting, I was more approaching this from the developer perspective but both audiences can be served with the same view.
Regarding those lines, the view didn't work without them for me. Without them the view didn't render. Are you saying the popup is always showing even if you are not actively talking to the assistant?

@dinki
Copy link
Owner

dinki commented Jan 23, 2025

Hmm.. Odd for sure. My brain is mush from a pretty long day at work. Will look at it closer tomorrow.

@Flight-Lab
Copy link
Contributor

I really like v2!

@jeroenterheerdt
Copy link
Contributor Author

one thing I don't like about V2 is that the title is not shown (it just says: "Troubles..."). Not sure how to fix that.

But those are small issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants