Ability to get the game detalization using slug

dimuska139 · Jun 1, 2022 · dd32f81 · dd32f81
1 parent 84cc5c4
commit dd32f81
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 10 deletions.
diff --git a/src/Filters/Filter.php b/src/Filters/Filter.php
@@ -11,7 +11,7 @@ abstract class Filter
      */
     public function toArray(): array
     {
-        return array_filter(get_object_vars($this), function($element){
+        return array_filter(get_object_vars($this), static function($element){
             return !is_null($element);
         });
     }

diff --git a/src/Resources/GamesResource.php b/src/Resources/GamesResource.php
@@ -82,13 +82,13 @@ public function getStores(int $id, OrderingFilter $filter): Response
     }
 
     /**
-     * @param int $id
+     * @param int|string $idOrSlug
      * @return Response
      * @throws ApiException
      */
-    public function getGame(int $id): Response
+    public function getGame($idOrSlug): Response
     {
-        return $this->get("/games/$id");
+        return $this->get("/games/$idOrSlug");
     }
 
     /**

diff --git a/tests/unit/Resources/DevelopersResourceTest.php b/tests/unit/Resources/DevelopersResourceTest.php
@@ -35,8 +35,8 @@ public function testGetDeveloper()
         $cfg = new Config(getenv(ENV_API_KEY));
         $client = new ApiClient($cfg);
 
-        $response = $client->developers()->getDeveloper(1);
+        $response = $client->developers()->getDeveloper(405);
         $this->assertEquals(Status::HTTP_OK, $response->getResponse()->getStatusCode());
-        $this->assertEquals("D3 Publisher of America", $response->getData()['name']);
+        $this->assertEquals("Ubisoft", $response->getData()['name']);
     }
 }
diff --git a/tests/unit/Resources/GamesResourceTest.php b/tests/unit/Resources/GamesResourceTest.php
@@ -98,14 +98,24 @@ public function testGetStores()
         $this->assertNotCount(0, $response->getData()['results']);
     }
 
-    public function testGetGame()
+    public function testGetGameById()
     {
         $cfg = new Config(getenv(ENV_API_KEY));
         $client = new ApiClient($cfg);
 
-        $response = $client->games()->getGame(1);
+        $response = $client->games()->getGame(4286);
         $this->assertEquals(Status::HTTP_OK, $response->getResponse()->getStatusCode());
-        $this->assertEquals("D/Generation HD", $response->getData()['name']);
+        $this->assertEquals("BioShock", $response->getData()['name']);
+    }
+
+    public function testGetGameBySlug()
+    {
+        $cfg = new Config(getenv(ENV_API_KEY));
+        $client = new ApiClient($cfg);
+
+        $response = $client->games()->getGame('bioshock');
+        $this->assertEquals(Status::HTTP_OK, $response->getResponse()->getStatusCode());
+        $this->assertEquals("BioShock", $response->getData()['name']);
     }
 
     public function testGetArchievements()
@@ -157,7 +167,7 @@ public function testGetTwitch()
         $cfg = new Config(getenv(ENV_API_KEY));
         $client = new ApiClient($cfg);
 
-        $response = $client->games()->getTwitchVideos(1);
+        $response = $client->games()->getTwitchVideos(10213);
         $this->assertEquals(Status::HTTP_OK, $response->getResponse()->getStatusCode());
         $this->assertNotNull($response->getData()['count']);
         $this->assertNotCount(0, $response->getData()['results']);