test: add test coverage for statistic-related methods #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements tests recommended in #1320 (comment)
Want to call out some potential oddness related to the edge case tests for the
productmethod. I've set it up so the tests pass since these edge cases don't seem too realistic, but wanted to point out regardless.The callout is that
0 x 0,m x 0, and0 x nevaluate to 1.https://github.com/mdahlin/nalgebra/blob/test_statistics/src/base/statistics.rs#L673
Similar results are also seen in the row/column products as well
https://github.com/mdahlin/nalgebra/blob/test_statistics/src/base/statistics.rs#L708