Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ivorycoast country map #2

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ajeety4
Copy link
Collaborator

@ajeety4 ajeety4 commented Sep 5, 2024

SUMMARY

Adds the Ivory Coast Country map.

The instructions were followed from the guide here

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshots showing that the country is now avaialble in the country map chart.
image

image

TESTING INSTRUCTIONS

Create a new country map chart after rebuilidng the frontend and you should see the new country displayed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@Charl1996
Copy link
Collaborator

@ajeety4 Where did you get the geojson values in superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/ivory_coast.geojson?

@ajeety4
Copy link
Collaborator Author

ajeety4 commented Sep 9, 2024

@ajeety4 Where did you get the geojson values in superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/ivory_coast.geojson?

In this superset guide, this first step has instructions to generate the geojson file. Note that it uses this www.naturalearthdata.com source to get the map.

@ajeety4 ajeety4 merged commit f99144f into 3.1.0-dimagi-2-branch Sep 18, 2024
54 of 75 checks passed
@ajeety4 ajeety4 deleted the ay/adds-ivory-coast-map branch September 18, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants