Move Participant models from the experiments app to the participants app #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snopoke for your review. Happy to create a ticket and link these changes for future implementation |
snopoke
reviewed
Jun 13, 2024
| .distinct() | ||
| ) | ||
|
|
||
| class Meta: |
There was a problem hiding this comment.
you'll also need to specify the db_table here since the table is called experiments_participant.
Alternately you could include the rename in the migrations.
|
Closing to minimize PR clutter. I created an issue to tackle this and linked this PR to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three ways one can approach moving models to a new app. I opted for the django way where one create the migrations, but use the SeparateDatabaseAndState operation to update django's state by running the original migrations only on the state. The DB operations to delete the tables from the
experimentsapp and create them in theparticipantsapp should be overwritten to rather just rename the table.Initial testing showed that nothing breaks, but this doesn't mean it's working as expected. I still have to ensure I know exactly what happens to the indexes and unique constraints that would have been removed. My code just leaves them alone, which I suspect is wrong. Maybe we should rename them as well. For now, I'm parking this change until we decide to tackle it.