Support Endpoints for Instance Datums #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
shubham1g5
force-pushed
the
instanceEndpoint
branch
from
62dfa10
to
8ae244d
Compare
…ected cases instance actually have the right case ids
shubham1g5
force-pushed
the
instanceEndpoint
branch
from
8ae244d
to
14f05d0
Compare
3 tasks
shubham1g5
added
the
product/custom
|
@snopoke bumping review request for this and corresponding core PR. |
snopoke
approved these changes
Aug 16, 2023
| if(argument.isInstanceArgument()){ | ||
| String argumentValue = argumentValues.get(argument.getId()); | ||
| String instanceSrc = argument.getInstanceSrc(); | ||
| if (instanceSrc.contentEquals(JR_SELECTED_ENTITIES_REFERENCE)) { |
There was a problem hiding this comment.
should this error if the instanceSrc is something else?
Sorry for the delay. These changes look good to me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Refer to Spec
Safety Assurance
Safety story
Testing on staging
Automated test coverage
Added a few tests to complement this, we have tests on multi-select case lists already which should cover for any regressions.
QA Plan
Not planning
Special deploy instructions
Rollback instructions
Review
cross-request: dimagi/commcare-core#1312