Escape 'regex' in Case Search #35401
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (simple string replacement
minhaminha
requested review from
orangejenny,
MartinRiese,
esoergel,
AddisonDunn,
stephherbers,
Robert-Costello and
Jtang-1
as code owners
Robert-Costello
approved these changes
Nov 19, 2024
MartinRiese
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Limited to Superuser use.
Technical Summary
Jira Ticket
This was most likely an effort to duplicate the behavior of Remove Special Characters (under project settings) where despite being referred to as regex in the code, everything user facing and it being eventually escaped suggests it's actually just supposed to be a string for use in a simple string replacement operation.
This is also to address this code scan alert
Feature Flag
Not an FF but limited to Superusers
Safety Assurance
Safety story
Tested locally. Escapes a string and changes a string so no real impact.
Rollback instructions
Labels & Review