Make domain regex more specific #35396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only match urls that have /a/ in them * domain names can only be 25 characters long * domain names cannot have spaces or slashes in them. so make the group more specific
MartinRiese
force-pushed
the
riese/regex_domain
branch
from
7915149
to
17d2399
Compare
nospame
reviewed
Nov 19, 2024
nospame
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
group more specific
Technical Summary
https://dimagi.atlassian.net/browse/SAAS-16188
Feature Flag
None
Safety Assurance
tested locally
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review