[webpack] Migrate a few tempus dominus pages #35383
Conversation
Registry edit page needs multiselect, which isn't yet supported with webpack.
| @@ -3,7 +3,8 @@ hqDefine("app_execution/js/workflow_charts", [ | |||
| 'jquery', | |||
| 'moment/moment', | |||
| 'd3/d3.min', | |||
| 'nvd3/nv.d3.latest.min', // version 1.1.10 has a bug that affects line charts with multiple series | |||
| 'nvd3-1.8.6', // version 1.1.10 has a bug that affects line charts with multiple series | |||
There was a problem hiding this comment.
Version numbers should normally only be in package.json so we don't have to change other files when upgrading. Is it possible to use some alias/name that does not include the version number?
There was a problem hiding this comment.
That makes sense. I added an alias in the webpack config so that application code doesn't need the version number, does that work? 429a2ca
| @@ -13,6 +13,8 @@ const aliases = { | |||
| // remove this file and the yarn modernizr post-install step | |||
| "modernizr": "hqwebapp/js/lib/modernizr", | |||
|
|
|||
| "nvd3/nv.d3.latest.min": "nvd3-1.8.6/build/nv.d3.min", | |||
There was a problem hiding this comment.
I suppose this is fine since it looks like dependabot will never upgrade this library (because package.json depends on the specific version). That doesn't seem like an ideal situation, but I don't have a better suggestion if that's the only way to get the version we need.
There was a problem hiding this comment.
I wonder if the comment // version 1.1.10 has a bug that affects line charts with multiple series should be moved over here?
Technical Summary
Update tempus dominus config for webpack, migrated a couple of pages.
Safety Assurance
Safety story
The only non-flagged page is user API keys, which I've smoke tested on staging.
Automated test coverage
no
QA Plan
no
Rollback instructions
Labels & Review