Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer treat "0 0" as null since it is a valid coordinate #35369

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Nov 14, 2024

Product Description

Revert changes applied in this PR for "0 0" coordinates

Revert changes such that it is as below.

  A. If the case list contains only that case B. If the case list also contains other cases that have non-empty coordinates
A case in the case list has map coordinates of 0 0 The 0 0 coordinate is (arguably correctly) shown on the map The 0 0 coordinate is (arguably correctly) shown on the map

Technical Summary

After further discussion on this ticket, we decided it was more appropriate to clean data input such that values are empty instead of "0 0".

Feature Flag

USH: Allow use of a map in the case list in Web Apps

Safety Assurance

Safety story

Tested locally. Impacts only case list address mapping

Automated test coverage

No automated test

QA Plan

no QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Nov 14, 2024
@Jtang-1 Jtang-1 marked this pull request as ready for review November 14, 2024 20:30
@Jtang-1 Jtang-1 mentioned this pull request Nov 14, 2024
3 tasks
@AddisonDunn
Copy link
Contributor

more appropriate to clean data input such that values are empty instead of "0 0"

Sounds like it was from an external data system? Definitely feels more appropriate to fix in the data cleaning/integration rather than a custom check in the code.

@Jtang-1 Jtang-1 merged commit 57f87e7 into master Nov 14, 2024
12 checks passed
@Jtang-1 Jtang-1 deleted the jt/handling-map-coordinates branch November 14, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants