Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for CommCare release 2.54 #35082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avazirna
Copy link

@avazirna avazirna commented Sep 3, 2024

Product Description

CommCare 2.54 translations update.

commcare-translations PR: dimagi/commcare-translations#82

@avazirna avazirna added the product/invisible Change has no end-user visible impact label Sep 3, 2024
@avazirna avazirna self-assigned this Sep 3, 2024
@AmitPhulera
Copy link
Contributor

@avazirna Test failures look related -

  ======================================================================
  FAIL: corehq.apps.app_manager.tests.test_translation_file_paths:test_version_paths_with_latest_commcare_version ()
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/vendor/lib/python3.9/site-packages/nose/case.py", line 198, in runTest
      self.test(*self.arg)
    File "/mnt/commcare-hq-ro/corehq/apps/app_manager/tests/test_translation_file_paths.py", line 21, in test_version_paths_with_latest_commcare_version
      eq(
    File "/vendor/lib/python3.9/site-packages/testil.py", line 54, in eq
      raise AssertionError(err)
  AssertionError: not equal
  ['../historical-translations-by-version/2.54-messages_en-2.txt', '../messages_en-1.txt']
  ['../historical-translations-by-version/2.53-messages_en-2.txt', '../messages_en-1.txt']
  
  ----------------------------------------------------------------------

Are there any other steps that we need to follow to release a new version?

@avazirna
Copy link
Author

avazirna commented Sep 4, 2024

@avazirna Test failures look related -

  ======================================================================
  FAIL: corehq.apps.app_manager.tests.test_translation_file_paths:test_version_paths_with_latest_commcare_version ()
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/vendor/lib/python3.9/site-packages/nose/case.py", line 198, in runTest
      self.test(*self.arg)
    File "/mnt/commcare-hq-ro/corehq/apps/app_manager/tests/test_translation_file_paths.py", line 21, in test_version_paths_with_latest_commcare_version
      eq(
    File "/vendor/lib/python3.9/site-packages/testil.py", line 54, in eq
      raise AssertionError(err)
  AssertionError: not equal
  ['../historical-translations-by-version/2.54-messages_en-2.txt', '../messages_en-1.txt']
  ['../historical-translations-by-version/2.53-messages_en-2.txt', '../messages_en-1.txt']
  
  ----------------------------------------------------------------------

Are there any other steps that we need to follow to release a new version?

Not that I'm aware of, let me try to understand why that test failed.

@avazirna
Copy link
Author

avazirna commented Sep 4, 2024

@biyeun I see that you added add tests for commcare-translation file paths with hardcoded paths, is there any other step we need to take to update the translations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants