Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate migration alerts into deploy #3970

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Integrate migration alerts into deploy #3970

merged 6 commits into from
Jul 22, 2020

Conversation

esoergel
Copy link
Contributor

Implements dimagi/commcare-hq#27838, using @AliRizvi1 's work in #3951

[10.201.11.173] Executing task 'deploy_commcare'
List of PRs since last deploy:
1. Bump statici18n to version supporting Django 2.2 https://github.com/dimagi/commcare-hq/pull/28084 | product/invisible
2. [ICDS Dashboard] Pull the program summary data on the same level https://github.com/dimagi/commcare-hq/pull/28075 | product/custom
3. Fix sorting for FCT count column https://github.com/dimagi/commcare-hq/pull/28087 | product/all-users-all-environments
Are you sure you want to preindex and deploy to staging? [y/N] y

Since this significantly increases API requests to github, all users are now prompted to set up a github API key, though they can still abstain.

It also drops the use of git tags for diff URLs, instead, it always inspects the code root for the currently deployed commit. We did this already as a fallback, and I don't know that there was ever a good reason to not always do that.

The unauthenticated rate limiting is really low, like 60 requests an
hour.
Looks like it became irrelevant in 4de0598
It isn't actually necessary to use tags to track this
@esoergel
Copy link
Contributor Author

bump

@esoergel esoergel merged commit 2887c69 into master Jul 22, 2020
@esoergel esoergel deleted the es/deploy-diff branch July 22, 2020 14:47
Copy link
Contributor

@kaapstorm kaapstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this. This is really cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants