Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes form navigation error due to multiple search callout extras #2867

Open
wants to merge 1 commit into
base: commcare_2.54
Choose a base branch
from

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Oct 1, 2024

Summary

https://dimagi.atlassian.net/browse/SUPPORT-22243

Product Description

Bug fix: Fixes form navigation error due to multiple search callout extras

Repro:

  1. Use case search list callout to search and filter the case list
  2. Make a case selection to enter into a form
  3. Exit the form without saving and go back to the case list
  4. Select the case again from filtered case list and go into the form again
  5. Form errors with an error -"Multiple Extras found with key entity-list-data"

Technical Summary

On making a case selection from the case list filtered with a callout, we add an extra called entity-list-data to the top frame step. On re-selecting the case from case list, this extra ends up getting added again to the frame step which eventually errors when user opens the form with exception thrown from here.

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

None.

Safety story

Small change to remove the extra before adding. Locally tested.

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

1 similar comment
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant