Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not save read only forms #2835

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Do not save read only forms #2835

merged 2 commits into from
Sep 5, 2024

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Sep 5, 2024 •
edited
Loading

Summary

Makes 2 changes in context of completed/read only forms -

  1. Do not allow re-saving completed forms
  2. Reword Form's "FINISH" button to say "EXIT" for completed forms

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Safety story

Tested locally and verified that we are able to save non-completed forms as usual.

@shubham1g5 shubham1g5 changed the base branch from master to feature/givewell September 5, 2024 07:37
@shubham1g5 shubham1g5 marked this pull request as ready for review September 5, 2024 07:56
@shubham1g5 shubham1g5 added this to the 2.54.1 milestone Sep 5, 2024
@shubham1g5 shubham1g5 mentioned this pull request Sep 5, 2024
Closed
3 tasks
avazirna
avazirna approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@avazirna avazirna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@shubham1g5 shubham1g5 merged commit 824da79 into feature/givewell Sep 5, 2024
1 check failed
@shubham1g5 shubham1g5 deleted the doNotSaveReadOnlyForms branch September 5, 2024 11:55
@avazirna avazirna mentioned this pull request Sep 13, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avazirna avazirna avazirna approved these changes

@ctsims ctsims Awaiting requested review from ctsims

Assignees
No one assigned
Labels
product/all-users
Projects
None yet
Milestone
2.54.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @avazirna