Add Incomplete forms option to Root menu as Home Screen #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
reviewed
Aug 30, 2024
| @@ -229,8 +229,7 @@ private static int getItemIcon(String id) { | |||
| case SAVED_FORMS_ITEM_ID: | |||
| return R.drawable.ic_saved_forms_nav_drawer; | |||
| case INCOMPLETE_FORMS_ITEM_ID: | |||
| //TODO: Need to add an icon for this option | |||
| return -1; | |||
| return R.drawable.ic_incomplete_nav_drawer; | |||
There was a problem hiding this comment.
can we not use the existing home_incomplete.xml ?
There was a problem hiding this comment.
@shubham1g5 I considered that but it would distort the look and feel, no? In that mode all, the icons are grey and the home_incomplete is coloured and requires a background:
avazirna
force-pushed
the
add-incomplete-forms-option-to-root-module-menu
branch
from
2258ed3
to
02b4e46
Compare
|
@shubham1g5 I changed the icon to a vector drawable and made the necessary changes to the layout for it to scale as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is just to add a new navigation drawer item for Incomplete forms, so users can easily access forms that have been saved as incomplete.
Feature Flag
This is related to the
Incomplete formsfeature and the custom propertycc-use-root-menu-as-home-screen.Product Description
This is how the navigation drawer looks like with the addition:
Safety Assurance
Safety story
This just adds a menu item to an existing feature.