Auto-Save Form on Pause #2802
Merged
Auto-Save Form on Pause #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
commented
Aug 7, 2024
| public String getSerializedFormIndex() { | ||
| try{ | ||
| byte[] serializedFormIndex = SerializationUtil.serialize(getFormIndex()); | ||
| return Base64.encodeToString(serializedFormIndex, Base64.DEFAULT); |
There was a problem hiding this comment.
can the value for Base64.DEFAULT change with OS updates ? If so, I would like to pass a concrete encoding here like Charset.forName("UTF-8")
There was a problem hiding this comment.
That's a good point, I'm not sure, let's lean to the safe side (but I will take note and look into that later)
| byte[] serializedFormIndex = SerializationUtil.serialize(getFormIndex()); | ||
| return Base64.encodeToString(serializedFormIndex, Base64.DEFAULT); | ||
| } catch (Exception e){ | ||
| return null; |
There was a problem hiding this comment.
Think it's better to fail fast here instead of swallowing the errors here unless there is a strong reason to do otherwise. At the very least we should be logging the exceptions encountered here.
There was a problem hiding this comment.
Actually think again it makes sense to catch any errors here as we would not want to loose on saving form because of an error here.
avazirna
force-pushed
the
saveFormOnPause
branch
from
53033e5
to
40789ed
Compare
avazirna
force-pushed
the
saveFormOnPause
branch
from
40789ed
to
cff229f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context Doc
Feature Flag
None at the moment, will be behind a custom property when merged to
masterProduct Description
Auto-Saves a CC form when CC goes in background
Safety Assurance
Automated test coverage
None
Safety story
We call an existing method we already use to save form session at the time of user session expiry
cross-request: dimagi/commcare-core#1426