Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 13 Tests Updates #2709

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Android 13 Tests Updates #2709

merged 4 commits into from
Sep 22, 2023

Conversation

avazirna
Copy link
Contributor

Summary

This PR brings a few changes needed to our Instrumentation Tests to successfully run on Android 13.

Safety Assurance

  • I have confidence that this PR will not introduce a regression for the reasons below

@avazirna avazirna self-assigned this Sep 21, 2023
shubham1g5
shubham1g5 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we try adding a Android 13 device on Browserstack to see how well our tests run on Browserstack for an Android 13 device. It would be great to add more variety across Android OS versions in BS test runs.

@avazirna
Copy link
Contributor Author

Looks good, can we try adding a Android 13 device on Browserstack to see how well our tests run on Browserstack for an Android 13 device. It would be great to add more variety across Android OS versions in BS test runs.

Yeah, I was looking at the supported devices yesterday and they have many options.

@avazirna
Copy link
Contributor Author

@damagatchi retest this please

@avazirna avazirna merged commit 836cfd2 into master Sep 22, 2023
3 of 7 checks passed
@avazirna avazirna deleted the android_13_test_updates branch September 22, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham1g5 shubham1g5 shubham1g5 approved these changes

Assignees

@avazirna avazirna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avazirna @shubham1g5