Backmerge Commcare 2.53.1 #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fix Fix Zip path traversal vulnerability
Set audio recorder sample rate
ctsims
reviewed
Jul 31, 2023
app/AndroidManifest.xml
Outdated
| @@ -3,7 +3,7 @@ | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
| android:versionCode="106" | |||
| android:versionName="2.53"> | |||
| android:versionName="2.53.1"> | |||
There was a problem hiding this comment.
I think the versionName tags shouldn't change on backmerges, right, or am I wrong on that? I think we try and reserve point released version ID's for non-main branches, and keep the main branch on a generic working version ID
There was a problem hiding this comment.
Correct, let me fix this
ctsims
reviewed
Jul 31, 2023
|
@damagatchi retest this please |
|
@damagatchi retest this please |
ctsims
approved these changes
Jul 31, 2023
|
@damagatchi retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR back-merges changes from CommCare 2.53.1 into the
masterbranch.