disbaling death on strict mode violations #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
assigned OrangeAndGreen and avazirna and unassigned OrangeAndGreen and avazirna
avazirna
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
@shubham1g5 what do you think about creating an Issue about this, so we can make sure it gets picked in the future.
yeah that sounds right to me, added one here |
|
@damagatchi retest this please |
1 similar comment
|
@damagatchi retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Strict mode crashes is making it impossible today to debug application without crashing. I am disabling it for now and we should turn it back on once we are able to solve for existing violations.
Safety Assurance
Automated test coverage
NA
Safety story
Only affect debug apk.