Add archived posts and stories feeds #1285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
reviewed
Sep 29, 2020
|
|
||
| async request(): Promise<any> { | ||
| const { body } = await this.client.request.send({ | ||
| url: '/api/v1/feed/only_me_feed/', |
There was a problem hiding this comment.
The file should be named only-me.feed.ts and thus the class OnlyMeFeed.
| //import { ArchivedFeedResponseRootObject, ArchivedFeedResponseMedia } from '../responses'; // new | ||
| //import { SavedFeedResponseRootObject, SavedFeedResponseMedia } from '../responses'; | ||
|
|
||
| export class ArchivedPostsFeed extends Feed<any, any> { |
There was a problem hiding this comment.
The Feed should have proper types, not <any, any>.
| //import { ArchivedFeedResponseRootObject, ArchivedFeedResponseMedia } from '../responses'; // new | ||
| //import { SavedFeedResponseRootObject, SavedFeedResponseMedia } from '../responses'; | ||
|
|
||
| export class ArchivedStoriesFeed extends Feed<any, any> { |
There was a problem hiding this comment.
Add types (see comment above)
|
|
||
| async request(): Promise<any> { | ||
| const { body } = await this.client.request.send({ | ||
| url: '/api/v1/archive/reel/day_shells/', |
There was a problem hiding this comment.
Rename file to day-shells.feed.ts and class to DayShellsFeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.