Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add embedded file(s) to catalog #27

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

dhernandez
Copy link

Fix #10

@vanbroup
Copy link
Member

Thanks for addressing this issue.

Can you also add a test to avoid any regression in the future?

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.81%. Comparing base (3fe840b) to head (e5e1f22).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   52.14%   48.81%   -3.33%     
==========================================
  Files          10       13       +3     
  Lines         629      932     +303     
==========================================
+ Hits          328      455     +127     
- Misses        227      388     +161     
- Partials       74       89      +15     
Flag Coverage Δ
unittests 48.81% <100.00%> (-3.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vanbroup vanbroup merged commit c34fd5f into digitorus:main Mar 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing a PDF with attachment results in a signed PDF without attachment
2 participants