Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visitor reactions #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timiwahalahti
Copy link
Contributor

@timiwahalahti timiwahalahti commented Oct 31, 2024

In JS visitorId fingerprint was not flowing all the way thru to function that makes the actual request to add reaction. This lead to all visitors (not logged in users) getting visitorId of 0.

That in return caused havoc, as all visitors were treated as they would be the same. If some visitor had reacted with heart, then next visitor actually deducted that heart away.

Build the dist file ready for shipment and bumped the version to 1.0.2 on the same go so that this should be ready for release as is.

props @anttiroosem

Copy link

height bot commented Oct 31, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant