avoid too many verbose logs on production. Lots of logs are not neces…

… sary because there is already throw Exception that can be catched by application
digitick · Jun 6, 2018 · 735c07c · 735c07c
1 parent 59fc7fc
commit 735c07c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/src/Digitick/Foundation/Fuse/Command/Http/HttpCommand.php b/src/Digitick/Foundation/Fuse/Command/Http/HttpCommand.php
@@ -349,22 +349,23 @@ private function exceptionFactory(TransferException $exc)
             switch ($exc->getCode()) {
 
                 case NotFoundException::STATUS_CODE :
-                    $this->warning("Throw exception of type NotFoundException");
+                    $this->debug("Throw exception of type NotFoundException");
                     $thrownException = new NotFoundException ($exc->getMessage(), $exc->getCode(), $exc);
                     break;
 
                 case ForbiddenException::STATUS_CODE :
-                    $this->warning("Throw exception of type ForbiddenException");
+                    //avoid too many verbose logs on production
+                    $this->debug("Throw exception of type ForbiddenException");
                     $thrownException = new ForbiddenException($exc->getMessage(), $exc->getCode(), $exc);
                     break;
 
                 case MethodNotAllowedException::STATUS_CODE :
-                    $this->warning("Throw exception of type MethodNotAllowed");
+                    $this->debug("Throw exception of type MethodNotAllowed");
                     $thrownException = new MethodNotAllowedException($exc->getMessage(), $exc->getCode(), $exc);
                     break;
 
                 case BadRequestException::STATUS_CODE :
-                    $this->warning("Throw exception of type MethodNotAllowed");
+                    $this->debug("Throw exception of type BadRequestException");
                     $thrownException = new BadRequestException($exc->getMessage(), $exc->getCode(), $exc);
                     break;
 
@@ -385,7 +386,7 @@ private function exceptionFactory(TransferException $exc)
                     break;
 
                 case TemporaryUnavailableException::STATUS_CODE :
-                    $this->error("Throw exception of type NotImplementedException");
+                    $this->error("Throw exception of type TemporaryUnavailableException");
                     $thrownException = new TemporaryUnavailableException($exc->getMessage(), $exc->getCode(), $exc);
                     break;
 

diff --git a/src/Digitick/Foundation/Fuse/Command/Soap/SoapCommand.php b/src/Digitick/Foundation/Fuse/Command/Soap/SoapCommand.php
@@ -122,12 +122,17 @@ public function send()
             $this->logSoapRequestAndResponse();
         } catch (SoapFault $fault) {
             $this->logSoapRequestAndResponse();
-            $this->error(sprintf("Transfer exception caught. Type : %s, status code = %s, message = %s",
+            $errorLog = sprintf("Transfer exception caught. Type : %s, status code = %s, message = %s",
                     get_class($fault),
                     $fault->getCode(),
                     $fault->getMessage()
-                )
             );
+            if ($fault->getCode() < 500) {
+                //avoid too many verbose logs on production
+                $this->debug($errorLog);
+            } else {
+                $this->error($errorLog);
+            }
             throw $fault;
         }
 

diff --git a/src/Digitick/Foundation/Fuse/Invoker/HttpCommandInvoker.php b/src/Digitick/Foundation/Fuse/Invoker/HttpCommandInvoker.php
@@ -158,7 +158,7 @@ public function executeAsync(HttpCommandInterface $command)
             }
         } catch (LogicException $exc) {
             $this->log(LogLevel::DEBUG, "Logic exception. Call onLogicError");
-            $this->log(LogLevel::INFO, "Success for command group " . $command->getKey());
+            $this->log(LogLevel::DEBUG, "Success for command group " . $command->getKey());
             $this->circuitBreaker->reportSuccess($command->getKey());
             return $command->onLogicError($exc);
         } catch (ServiceException $exc) {