path default values

[maheshsattala]

removed default values for the Path parameters.

Summary by CodeRabbit

• Refactor
  • Improved Single Sign-On (SSO) and Identity Provider (IdP) login and callback processes by making parameters mandatory.

[coderabbitai]

Walkthrough

Walkthrough

These modifications enhance the Single Sign-On (SSO) and Identity Provider (IdP) login functionalities within the authentication system by requiring explicit specification of parameters. The removal of default=None for certain parameters in both SSO and IdP related functions ensures that these values must be intentionally defined, improving the robustness and clarity of the authentication process.

Changes

File Path	Change Summary
.../auth.py	Removed default=None from sso_type in sso_login and sso_callback functions.
.../auth.py	Removed default=None from realm_name in idp_login and idp_callback functions.

🐇✨
In the realm of code where the rabbits play,
A change was made, oh hip hooray!
No more defaults hiding in the day,
Clear and explicit, is the only way!
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 706e6e8 and 3cbf0dd.

Files selected for processing (1)

• kairon/api/app/routers/auth.py (4 hunks)

Additional comments: 4

kairon/api/app/routers/auth.py (4)

• 145-145: The removal of default=None for the sso_type parameter in the sso_login function enforces explicit parameter specification. Ensure all calls to this function are updated accordingly.
• 156-156: The removal of default=None for the sso_type parameter in the sso_callback function enforces explicit parameter specification. Ensure all calls to this function are updated accordingly.
• 176-176: The removal of default=None for the realm_name parameter in the idp_login function enforces explicit parameter specification. Ensure all calls to this function are updated accordingly.
• 185-185: The removal of default=None for the realm_name parameter in the idp_callback function enforces explicit parameter specification. Ensure all calls to this function are updated accordingly.