feat(fileUpload): styling for fileUpload component #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamo225
changed the title
andreasphil
force-pushed
the
risdev_4778_file_upload
branch
2 times, most recently
from
c9dcb11 to
e546ce8
Compare
This also introduces Mock Service Worker for Storybook, so we can easily mock and test API interactions (such as the file upload) in a way that is as close as possible to how it would work in an actual application. RISDEV-4778
When a button has an icon, we used to reduce padding on the side where the icon is to make it look more balanced. Unfortunately, this only really has the desired effect for icons with a lot of whitespace (e.g. checkmarks), and looks broken for more "busy" icons (e.g. file upload). This commit removes special padding treatment for icons. The padding is always the same, whether there is an icon or not. This looks much better for the more busy icons, and still pretty good for icons with more whitespace.
andreasphil
force-pushed
the
risdev_4778_file_upload
branch
from
e546ce8 to
e9bbf3d
Compare
andreasphil
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISDEV-4778