Implemented /auth/callback and minor type refactor
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deeds67
changed the title
/auth/callback and minor type refactor
Deeds67
commented
Jan 7, 2025
| accessToken, | ||
| expiresAt, | ||
| }; | ||
|
|
||
| try { | ||
| const parsedUser = UserSchema.parse(user); |
There was a problem hiding this comment.
I deemed it unnecessary to validate the object structure here, since the cookie is signed, therefore we are sure that the cookie has the type that we set it to
There was a problem hiding this comment.
Good point. Additionally, unit tests may take care of any other errors later.
manuelpuchta
approved these changes
Jan 7, 2025
| accessToken, | ||
| expiresAt, | ||
| }; | ||
|
|
||
| try { | ||
| const parsedUser = UserSchema.parse(user); |
There was a problem hiding this comment.
Good point. Additionally, unit tests may take care of any other errors later.
Comment on lines
+16
to
+17
| export enum AuthenticationProvider { | ||
| BEA = "bea", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirect_uriswitch should be easy