Added a method to dump flows matching a flow #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpraveenraja
commented
Jan 22, 2024
dpraveenraja
commented
- Fixed a issue to match zeo ovscookie
- Added a method to dump flow using a flow filter
dpraveenraja
force-pushed
the
Dumpflows
branch
2 times, most recently
from
3c20058
to
fc97d88
Compare
anitgandhi
reviewed
Jan 25, 2024
ecbaldwin
reviewed
Jan 25, 2024
| @@ -105,7 +105,7 @@ func (f *MatchFlow) MarshalText() ([]byte, error) { | |||
| b = append(b, ',') | |||
| } | |||
|
|
|||
| if f.Cookie > 0 { | |||
| if f.Cookie > 0 || f.CookieMask > 0 { | |||
There was a problem hiding this comment.
What was the issue that you ran into that led to this change? Could you give a little more context? TIA!
There was a problem hiding this comment.
Cookie and CookieMask are uint64. So currently there is on way to match zero cookie or a zero cookie with a non-zero mask. So this check will enable use to check for zero cookie match. For example: cookie=0x0000000000000000/0xffffffffffffffff
1. Fixed a issue to match zeo ovscookie 2. Added a method to dump flow using a flow filter
dpraveenraja
force-pushed
the
Dumpflows
branch
from
fc97d88
to
a3e6e35
Compare
anitgandhi
reviewed
Jan 29, 2024
ecbaldwin
previously approved these changes
Jan 29, 2024
Co-authored-by: Anit Gandhi <[email protected]>
ecbaldwin
approved these changes
Jan 30, 2024
anitgandhi
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.