-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1618: Add tests for api token feature #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small findings. Rest looks good
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions.
Do you see a need to add tests for getApiTokenMetaData() as well?
Added |
…fabrik/entitlementcard into 1618-tests-for-api-token-feature
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Show resolved
Hide resolved
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
…vice/ApiTokenServiceTest.kt Co-authored-by: Tory <[email protected]>
…vice/ApiTokenServiceTest.kt Co-authored-by: Tory <[email protected]>
…vice/ApiTokenServiceTest.kt Co-authored-by: Tory <[email protected]>
…vice/ApiTokenServiceTest.kt Co-authored-by: Tory <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Just a minor find
backend/src/test/kotlin/app/ehrenamtskarte/backend/auth/webservice/ApiTokenServiceTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm 👍🏻
Short description
Added tests for the api token feature
Resolved issues
Fixes: #1618