Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1618: Add tests for api token feature #1694

Merged
merged 15 commits into from
Nov 12, 2024
Merged

Conversation

ztefanie
Copy link
Member

Short description

Added tests for the api token feature

Resolved issues

Fixes: #1618

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small findings. Rest looks good

Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions.
Do you see a need to add tests for getApiTokenMetaData() as well?

@ztefanie
Copy link
Member Author

ztefanie commented Nov 5, 2024

Added a few suggestions. Do you see a need to add tests for getApiTokenMetaData() as well?

Added

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Just a minor find

@ztefanie ztefanie enabled auto-merge (squash) November 12, 2024 09:52
Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm 👍🏻

@ztefanie ztefanie merged commit 171efd6 into main Nov 12, 2024
1 check passed
@ztefanie ztefanie deleted the 1618-tests-for-api-token-feature branch November 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Tests for api token feature
3 participants