Report error to sentry if initialization of userCodeModel fails #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
requested review from
steffenkleinle,
f1sh1918,
ztefanie and
seluianova
as code owners
f1sh1918
approved these changes
Sep 30, 2024
michael-markl
force-pushed
the
report-initialization-error
branch
from
ee9cde4
to
c1ff216
Compare
|
I noticed that the initialization is not awaited in the DeepLink activation workflow. So I did this now. I then noticed that the deeplink activation workflow lacks user feedback. I added a loading spinner and some barebones error feedback. The error handling should be improved in the future. |
michael-markl
force-pushed
the
report-initialization-error
branch
from
c1ff216
to
476d13d
Compare
f1sh1918
approved these changes
Oct 1, 2024
Also, if initialization fails, do not implicitly use empty array of user codes, but show error. Also throw Errors when using UserCodeModel when it is not properly initialized. Also add a loading spinner and some error popup to deeplink activation.
michael-markl
force-pushed
the
report-initialization-error
branch
from
476d13d
to
0124851
Compare
Done! #1656 |
ztefanie
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Report errors to sentry if initialization of UserCodeModel fails, instead of silently swallowing potentially thrown exceptions.
Also, if initialization fails, do not implicitly use empty array of user codes, but show error.
Also throw Errors when using UserCodeModel when it is not properly initialized.
Side effects
If the initialization actually failed, the "Ausweisen" tab displays an error message now.
Testing
Activating card via Scanner and via Deeplink still works.
Activated cards survive app restart.
Resolved issues
Fixes: #1297
Related: #1265