Update docs #1619
Merged
Update docs #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
f1sh1918
commented
Sep 9, 2024
f1sh1918
commented
- added important note about backend config
- added koblenz project id in docs
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
commented
Sep 9, 2024
docs/production-setup.md
Outdated
| @@ -88,6 +88,12 @@ fvm flutter build ipa --flavor Bayern --release --dart-define=environment=produc | |||
|
|
|||
|
|
|||
| ### Backend and Administration | |||
|
|
|||
| #### Important: | |||
There was a problem hiding this comment.
please mind this @ztefanie , @seluianova, @steffenkleinle if you add any values to the backend config.yml
There was a problem hiding this comment.
ok, that is ugyl 😢
I think this hint should be in the config file in a comment, because then, when changing the file you get the reminder.
I created a ticket to solve this issue: #1627
There was a problem hiding this comment.
alright you can maybe connect with @svenseeberg to find a good solution
There was a problem hiding this comment.
oh sure i moved the comment to the config.yml
seluianova
approved these changes
Sep 9, 2024
steffenkleinle
approved these changes
Sep 9, 2024
docs/production-setup.md
Outdated
| @@ -88,6 +88,12 @@ fvm flutter build ipa --flavor Bayern --release --dart-define=environment=produc | |||
|
|
|||
|
|
|||
| ### Backend and Administration | |||
|
|
|||
| #### Important: | |||
| - any updates in the backend `config.yml` have to added/adjusted in salt before deployment! | |||
There was a problem hiding this comment.
Suggested change
| - any updates in the backend `config.yml` have to added/adjusted in salt before deployment! | |
| - All updates in the backend `config.yml` have to be added/adjusted in salt before deployment! |
ztefanie
requested changes
Sep 10, 2024
ztefanie
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.