Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DGS-2634] add BatchSendings and BatchSendingsItems endpoints #256

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

PavelVais
Copy link
Contributor

  • Implement BatchSendingsEndpoint for managing batch sendings.
  • Implement BatchSendingsItemsEndpoint for handling items within a batch.
  • Create BatchSending resource to represent batch sending data.
  • Add tests for BatchSendings and BatchSendingsItems endpoints.
  • Update DigiSign class to include batchSendings method.

Description

Describe your changes in detail.

Motivation and context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

pavelvais added 2 commits August 27, 2024 14:11
- Implement BatchSendingsEndpoint for managing batch sendings.
- Implement BatchSendingsItemsEndpoint for handling items within a batch.
- Create BatchSending resource to represent batch sending data.
- Add tests for BatchSendings and BatchSendingsItems endpoints.
- Update DigiSign class to include batchSendings method.
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (1ac1004) to head (b7c3f7f).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #256      +/-   ##
============================================
+ Coverage     97.49%   97.52%   +0.02%     
- Complexity      462      467       +5     
============================================
  Files            72       74       +2     
  Lines          1079     1089      +10     
============================================
+ Hits           1052     1062      +10     
  Misses           27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

public string $alias;

/**
* @var array<int, BatchSendingSlug>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

špatný typ

@spajxo spajxo merged commit 19f5cd2 into 2.x Aug 28, 2024
18 checks passed
@spajxo spajxo deleted the DGS-2634-batch-sendings branch August 28, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants