Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context.js and constants.js #1

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Update context.js and constants.js #1

merged 5 commits into from
Jan 31, 2022

Conversation

JSAssassin
Copy link
Contributor

No description provided.

@JSAssassin JSAssassin marked this pull request as draft January 27, 2022 17:22
@JSAssassin JSAssassin marked this pull request as ready for review January 27, 2022 21:26
js/context.js Outdated Show resolved Hide resolved
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks @JSAssassin!

@davidlehn
Copy link
Member

Re syncing js and json issues: I think the theory of this newer template style is that developers should just edit the js and use the serialize script to generate and commit the JSON. @dmitrizagidulin should confirm. I assume the generated JSON is supposed to be in git? The build script is going to run serialize anyway so I think the main purpose for the JSON in the repo is for local testing?

@dmitrizagidulin
Copy link
Contributor

@davidlehn - good question. Yes, the generated JSON is supposed to be committed to Git. The reason for that is -- for many of the contexts this template serves, the w3id URL resolves to that very same generated JSON file, hosted via Github Pages.
Meaning, the main purpose for the JSON is not for local testing, but for serving the context on the web.

@davidlehn
Copy link
Member

@dmitrizagidulin Ah yes, I forgot that use case. Would be good to figure out how to write a github action that checks to make sure js and json are in sync. As was seen here, that can be an issue and is difficult to spot.

@davidlehn
Copy link
Member

Added tracking issue: digitalbazaar/context-template#6

@JSAssassin JSAssassin merged commit 835e576 into main Jan 31, 2022
@JSAssassin JSAssassin deleted the initial branch January 31, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants