Allow custom authenticatedAttributes #991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling inside forge attributes like messageDigest and signingTime is really nice, but not allowing any other attributes is quite limiting. This change allow the user to build and use any attribute with ASN.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling inside forge attributes like messageDigest and signingTime is
really nice, but not allowing any other attributes is quite limiting.
This change allow the user to build and use any attribute with ASN.1.
This problem have been addressed in #400 but no PR were open. I used the name asn1Value instead of rawValue because I think rawValue would be misleading.
An example of the need for this is in #768 where it is proposed a new attribute signingCertificateV2, but signingCertificateV2 can be way more complex than the version proposed. sigPolicyId is another example of attribute that would be quite hard to implement in a general form but is not hard to build for an specific policy.