Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance URL validation in console logger #1103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LaelLuo
Copy link

@LaelLuo LaelLuo commented Dec 7, 2024

Changes

  • Add URL API availability check before using URL constructor
  • Include typeof URL !== 'undefined' condition to prevent errors in environments without URL API support

Why

  • Some older browsers or special runtime environments may not support the URL API
  • This check prevents ReferenceError from being thrown in such environments

Impact

  • Improves code robustness and compatibility
  • No functional changes in modern browsers that support URL API

Fixes potential ReferenceError when URL API is not available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant